Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PubSub: Update region tags to standard #3281

Merged
merged 1 commit into from
May 21, 2018
Merged

PubSub: Update region tags to standard #3281

merged 1 commit into from
May 21, 2018

Conversation

alixhami
Copy link
Contributor

No description provided.

@alixhami alixhami added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: pubsub Issues related to the Pub/Sub API. labels May 16, 2018
@alixhami alixhami requested a review from jabubake May 16, 2018 21:09
@alixhami alixhami requested a review from pongad as a code owner May 16, 2018 21:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 16, 2018
pongad
pongad reviewed May 16, 2018
View reviewed changes
Copy link
Contributor

@pongad pongad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the place these get written to as well?

@alixhami
Copy link
Contributor Author

@pongad Yes, I am submitting PRs to all the languages to standardize the region tags, and the do not merge label will be on all the PRs until they are all ready and I can update the docs site at the same time.

jabubake
jabubake approved these changes May 18, 2018
View reviewed changes
Copy link
Contributor

@jabubake jabubake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pongad
Copy link
Contributor

pongad commented May 18, 2018

OK, LGTM but we're cutting a release now so let's hold off a little.

@alixhami alixhami removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 21, 2018
@alixhami alixhami merged commit 70adcab into master May 21, 2018
@alixhami alixhami deleted the alixhami-patch-1 branch May 21, 2018 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pongad pongad pongad left review comments

@jabubake jabubake jabubake approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alixhami @pongad @jabubake @googlebot