Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding note for spring boot with tc #2053

Merged
merged 2 commits into from
May 10, 2017
Merged

adding note for spring boot with tc #2053

merged 2 commits into from
May 10, 2017

Conversation

jabubake
Copy link
Contributor

#2039
(Note : does not add link to all modules)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 10, 2017
garrettjonesgoogle
garrettjonesgoogle reviewed May 10, 2017
View reviewed changes
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the whitespace fix

README.md Outdated
@@ -822,6 +822,9 @@ This client is supported on Mac OS X, Windows and Linux (excluding Android and A
Google Cloud Platform environments currently supported include GCE, GKE and GAE Flex.
GAE Standard is not currently supported.

Spring Boot users : Native Tomcat is not currently supported. Please use [embedded Jetty](https://docs.spring.io/spring-boot/docs/current/reference/html/howto-embedded-servlet-containers.html#howto-use-jetty-instead-of-tomcat)

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 80.898% when pulling 12b2528 on jabubake:readme_springboot into c61a9c6 on GoogleCloudPlatform:master.

@jabubake jabubake merged commit 4e53991 into googleapis:master May 10, 2017
@jabubake jabubake deleted the readme_springboot branch May 10, 2017 21:09
@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.894% when pulling 699b1b6 on jabubake:readme_springboot into c61a9c6 on GoogleCloudPlatform:master.

lesv
lesv reviewed May 10, 2017
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments

@lesv lesv lesv left review comments

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jabubake @coveralls @lesv @garrettjonesgoogle @googlebot