Add DatastoreBackupOptions class for BigQuery #1757
Conversation
| * all properties. If any named property isn't found in the Cloud Datastore backup, an invalid | ||
| * error is returned in the job result. | ||
| */ | ||
| Builder setProjectionFields(List<String> projectionFields); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -54,7 +53,6 @@ | |||
| .setFormatOptions(CSV_OPTIONS) | |||
| .setIgnoreUnknownValues(IGNORE_UNKNOWN_VALUES) | |||
| .setMaxBadRecords(MAX_BAD_RECORDS) | |||
| .setProjectionFields(PROJECTION_FIELDS) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Changes Unknown when pulling e8f9472 on shinfan:master into ** on GoogleCloudPlatform:master**. |
googlebot
added
the
cla: yes
|
PTAL |
|
Changes Unknown when pulling 763ead9 on shinfan:master into ** on GoogleCloudPlatform:master**. |
| @@ -108,7 +107,11 @@ private Builder(com.google.api.services.bigquery.model.JobConfiguration configur | |||
| this.schema = Schema.fromPb(loadConfigurationPb.getSchema()); | |||
| } | |||
| this.ignoreUnknownValues = loadConfigurationPb.getIgnoreUnknownValues(); | |||
| this.projectionFields = loadConfigurationPb.getProjectionFields(); | |||
| if (loadConfigurationPb.getProjectionFields() != null) { | |||
| this.formatOptions = DatastoreBackupOptions.newBuilder() | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Two of the tests passed and the others failed due to timeout. I don't think it is caused by this PR. |
| * If no properties are specified, BigQuery loads all properties. If any named property isn't | ||
| * found in the Cloud Datastore backup, an invalid error is returned in the job result. | ||
| */ | ||
| Builder setProjectionFields(List<String> projectionFields) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| /** | ||
| * Google BigQuery options for Cloud Datastore backup. | ||
| */ | ||
| public final class DatastoreBackupOptions extends FormatOptions { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@michaelbausor PTAL |
|
Changes Unknown when pulling 0a76886 on shinfan:master into ** on GoogleCloudPlatform:master**. |
|
LGTM |
Fixes #552