Preventing logging re-entrance at FINE level #1523

garrettjonesgoogle · 2017-01-11T23:22:27Z

Also:

Reducing the scope of synchronized blocks
Removing logger exclusions except for Http2FrameLogger

Also: * Reducing the scope of synchronized blocks * Removing logger exclusions except for Http2FrameLogger

coveralls · 2017-01-12T00:38:16Z

Coverage decreased (-0.09%) to 83.454% when pulling 13ef687 on garrettjonesgoogle:master into d1e1c85 on GoogleCloudPlatform:master.

gregw · 2017-01-12T06:28:52Z

I testing this in https://github.com/GoogleCloudPlatform/jetty-runtime/tree/master-68-stackdriver and it works both locally and when deployed in the Flex environment. I was able to deploy with full FINE logging.

michaelbausor · 2017-01-12T18:30:37Z

LGTM, let @pongad take a look also

coveralls · 2017-01-12T21:01:21Z

Coverage decreased (-0.09%) to 83.454% when pulling a440983 on garrettjonesgoogle:master into d1e1c85 on GoogleCloudPlatform:master.

google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingHandler.java

@@ -272,23 +244,55 @@ Formatter getFormatterProperty(String name, Formatter defaultValue) {
   */
  Logging getLogging() {
    if (logging == null) {
-      logging = options.getService();
+      synchronized (this) {


google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingHandler.java

    }
  }

  /**
   * Closes the handler and the associated {@link Logging} object.
   */
  @Override
-  public synchronized void close() throws SecurityException {
+  public void close() throws SecurityException {


google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingHandler.java

+          buffer.add(entry);
+        }
+        if (buffer.size() >= flushSize || record.getLevel().intValue() >= flushLevel.intValue()) {
+          flushBuffer = buffer;


garrettjonesgoogle · 2017-01-13T01:36:45Z

PTAL

coveralls · 2017-01-13T02:30:38Z

Coverage decreased (-0.1%) to 83.449% when pulling 41ec178 on garrettjonesgoogle:master into d1e1c85 on GoogleCloudPlatform:master.

* Update version to 0.8.1-SNAPSHOT (#1467) Also, update versions in README to 0.8.0 * Add link to Maven Central for maven-central badge. (#1468) Used to link to the image, which wasn't super useful. * fix more races in pubsub tests Previously BlockingProcessStreamReader has a terminate() method, used to tell the Reader to stop reading from the emulator process. This causes an inter-process race. If the Reader stops before reading emulator's output, the emulator process will hang as it tries to write to stdout/stderr as there's no one to read from the other side of the pipe. Since there is no way to safely stop the Reader, this commit deletes the method and its associated test. Additionally, the timeout for LocalSystemTest is increased to 3 minutes, since the emulator, somehow, consistently takes just longer than a minute to shut down. * Regenerating SPI layer (#1501) * Converting Error Reporting and Monitoring to use resource name types * Removing formatX/parseX methods from pubsub, converting usage of the same to resource name types * New methods in Logging and PubSub * Updating grpc dependency to 1.0.3 (#1504) * Release 0.8.1 (#1512) * Fix code snippet (wrong method name) in README.md Original code snippet in _"Querying data"_ section: `..while (!queryResponse.jobComplete()) {..` This results in a compile error: _"Cannot resolve method jobComplete()"_ The correct method is `jobCompleted()` * Updating version in README files. [ci skip] * Update version to 0.8.2-alpha-SNAPSHOT * Allow path in URIs passed to newFileSystem (#1470) * This makes it easier for users who start with a URI describing a full path to get a FileSystem that can work with that path, since they no longer have to needlessly remove the path from the URI. Note that Oracle's description of newFileSystem [1] puts no restriction on the passed URI. [1] https://docs.oracle.com/javase/7/docs/api/java/nio/file/FileSystems.html#newFileSystem(java.net.URI,%20java.util.Map) * Preventing logging re-entrance at FINE level (#1523) * Preventing logging re-entrance at FINE level Also: * Reducing the scope of synchronized blocks * Removing logger exclusions except for Http2FrameLogger * Add a PathMatcher for CloudStorageFileSystem (#1469) Add a test, as well. We reuse the default PathMatcher since it does a fine job of globbing files. * Set timestamp from LogRecord (#1533) * Initialize the default MonitoredResource from a GAE environment (#1535) * BigQuery: Add support to FormatOptions for AVRO #1441 Added new constant in FormatOptions, and a corresponding factory method. Updated test cases. Confirmed that AVRO does not require special treatment (like CSV does), so no additional changes are required. * Reverting changed commited by mistake before review. * BigQuery: Add support to FormatOptions for AVRO #1441 Added new constant in FormatOptions and a corresponding factory method. Updated test cases. Confirmed that AVRO does not require special treatment (like CSV does), so no additional changes are required. * use RpcFuture and remove old BundlingSettings (#1572) * use RpcFuture and remove old BundlingSettings * Release 0.8.2 Note: This version was accidentally released to Sonatype because of experimenting with deployment commands, combined with the fact that autoReleaseAfterClose is set to true. Since releases can't be taken back, we might as well own up to the release and push the code forward. * Updating version in README files. [ci skip] * Fixing javadoc error in GaeFlexLoggingEnhancer (#1582) * get tests to compile and pass

Preventing logging re-entrance at FINE level

13ef687

Also: * Reducing the scope of synchronized blocks * Removing logger exclusions except for Http2FrameLogger

garrettjonesgoogle assigned pongad and michaelbausor Jan 11, 2017

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 11, 2017

Removing unused imports

a440983

pongad suggested changes Jan 13, 2017

View reviewed changes

Concurrency fix + simplification

41ec178

pongad approved these changes Jan 13, 2017

View reviewed changes

garrettjonesgoogle merged commit d4d494d into googleapis:master Jan 13, 2017

meltsufin mentioned this pull request Sep 1, 2017

Remove logger re-entrance safeguard from README GoogleCloudPlatform/jetty-runtime#208

Merged

theacodes unassigned pongad and michaelbausor Sep 28, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Preventing logging re-entrance at FINE level #1523

Preventing logging re-entrance at FINE level #1523

garrettjonesgoogle commented Jan 11, 2017 •

edited

Loading

coveralls commented Jan 12, 2017

gregw commented Jan 12, 2017

michaelbausor commented Jan 12, 2017

coveralls commented Jan 12, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

garrettjonesgoogle commented Jan 13, 2017

coveralls commented Jan 13, 2017

Preventing logging re-entrance at FINE level #1523

Preventing logging re-entrance at FINE level #1523

Conversation

garrettjonesgoogle commented Jan 11, 2017 • edited Loading

coveralls commented Jan 12, 2017

gregw commented Jan 12, 2017

michaelbausor commented Jan 12, 2017

coveralls commented Jan 12, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

garrettjonesgoogle commented Jan 13, 2017

coveralls commented Jan 13, 2017

garrettjonesgoogle commented Jan 11, 2017 •

edited

Loading