deflake SubscriberImplTest, maybe #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
davidtorres
approved these changes
Dec 22, 2016
|
Changes Unknown when pulling 6af9b99 on pongad:deflake-div0 into ** on GoogleCloudPlatform:pubsub-hp**. |
pongad
added a commit
that referenced
this pull request
Feb 7, 2017
This is the same race as #1495 but in sendStreamResponse rather than sendError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit tries to deflake failures reported in https://ci.appveyor.com/project/garrettjonesgoogle/google-cloud-java/build/57 .
The failure seems to come from
FakeSubscriberServiceImpl::sendError. When callinggetAndAdvanceCurrentStream, we waited for there to be a subscription by waiting on thesubscriptionInitializedvariable.The variable is notified before
addOpenedStreamis called though, and so it's possible thatgetAndAdvanceCurrentStreamwill see a list without any opened stream. The fix is to wait for at least one stream to be registered first.@davidtorres Another option seems to be moving
addOpenedStreaminto the synchronized block. I'm not sure which is the better option.