-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce gRPC dependency footprint, get rid of duplicate classes #1365
Reduce gRPC dependency footprint, get rid of duplicate classes #1365
Conversation
Maybe I should bump the priority of the dependency change in gax so that you don't have to make this mess. |
Actually GAX is not a big issue. We use GAX in our What is causing this mess is the fact that all proto artifacts depend on |
Ahh, the proto artifacts - how much would it help for me to update their dependencies too? |
My guess is that they only need It's not a problem to send out this PR and then remove the |
@@ -104,19 +104,42 @@ | |||
<version>3.0.0</version> | |||
</dependency> | |||
<dependency> | |||
<groupId>io.grpc</groupId> | |||
<artifactId>grpc-protobuf</artifactId> | |||
<version>1.0.1</version> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
LGTM |
@garrettjonesgoogle thanks for reviewing! |
This reduced gRPC dependencies that we include (in particular in the core module) fixes #1278 for good.
@anthmgoogle @garrettjonesgoogle any chance you can have a look? This can also be done at GAX layer to fix googleapis/gax-java#133. Also, is there a reason why proto artifacts (as
grpc-google-iam-v1
orgrpc-google-pubsub-v1
) depend on the wholegrpc-all
package? I believe that the dependency list there can be heavily reduced.