Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename setters/getters/builders for PubSub classes to meet proto conventions #1312

Merged
merged 3 commits into from
Oct 21, 2016

Conversation

mziccard
Copy link
Contributor

No description provided.

@mziccard mziccard added the api: pubsub Issues related to the Pub/Sub API. label Oct 10, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 10, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 84.664% when pulling 43b68f5 on mziccard:pubsub-rename into 513ca70 on GoogleCloudPlatform:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 84.664% when pulling a9e8397 on mziccard:pubsub-rename into 513ca70 on GoogleCloudPlatform:master.

@mziccard
Copy link
Contributor Author

/cc @lesv

Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I presume you'll update the example code in another PR.

@mziccard
Copy link
Contributor Author

I updated example with a9e8397, did I miss something?

@lesv
Copy link
Contributor

lesv commented Oct 11, 2016

No - I did. Sigh. I think that was the first file or two, saw it, but didn't register what it was. Thanks.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e037701 on mziccard:pubsub-rename into * on GoogleCloudPlatform:master*.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 84.561% when pulling e037701 on mziccard:pubsub-rename into 307f9f0 on GoogleCloudPlatform:master.

@lesv
Copy link
Contributor

lesv commented Oct 20, 2016

LGTM

@mziccard mziccard merged commit 82b5032 into googleapis:master Oct 21, 2016
github-actions bot pushed a commit that referenced this pull request Aug 18, 2022
…-info-reports-plugin to v3.4.1 (#1312)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) | `3.4.0` -> `3.4.1` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/compatibility-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/confidence-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-asset).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNjMuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE2My4wIn0=-->
github-actions bot pushed a commit to yoshi-code-bot/google-cloud-java that referenced this pull request Nov 8, 2022
…s#1687) (googleapis#1312)

* chore(java): add a note in README for migrated split repos

Disable renovate bot and flaky bot for split repositories
that have moved to the Java monorepo.
The Java monorepo will pass the "monorepo=True" parameter
to java.common_templates method in its owlbot.py files so that
the migration note will not appear in the README in the monorepo.

Co-authored-by: Jeff Ching <[email protected]>
Source-Link: https://togithub.com/googleapis/synthtool/commit/d4b291604f148cde065838c498bc8aa79b8dc10e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:edae91ccdd2dded2f572ec341a768ad180305a3e8fbfd93064b28e237d35920a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants