Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snippets to PubSub's javadoc, PubSubSnippets class and tests #1243

Merged
merged 4 commits into from
Sep 15, 2016
Merged

Add snippets to PubSub's javadoc, PubSubSnippets class and tests #1243

merged 4 commits into from
Sep 15, 2016

Conversation

mziccard
Copy link
Contributor

No description provided.

@mziccard mziccard added the docs label Sep 14, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 14, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.883% when pulling 5bcf665 on mziccard:pubsub-snippets into 9c840d6 on GoogleCloudPlatform:master.

@mziccard
Copy link
Contributor Author

/cc @lesv

lesv
lesv reviewed Sep 15, 2016
View reviewed changes
...cloud-examples/src/main/java/com/google/cloud/examples/logging/snippets/LoggingSnippets.java
@@ -134,7 +134,7 @@ public Sink updateSinkAsync(String sinkName, String datasetName)
public Sink getSink(String sinkName) {
// [START getSink]
Sink sink = logging.getSink(sinkName);
if (sink != null) {
if (sink == null) {

This comment was marked as spam.

Sign in to view

lesv
lesv reviewed Sep 15, 2016
View reviewed changes
...cloud-examples/src/test/java/com/google/cloud/examples/pubsub/snippets/ITPubSubSnippets.java
import java.util.UUID;
import java.util.concurrent.ExecutionException;

public class ITPubSubSnippets {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@lesv
Copy link
Contributor

lesv commented Sep 15, 2016

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.883% when pulling e0dbb7e on mziccard:pubsub-snippets into 9c840d6 on GoogleCloudPlatform:master.

@lesv
Copy link
Contributor

lesv commented Sep 15, 2016

LGTM

@mziccard mziccard merged commit b0f734e into googleapis:master Sep 15, 2016
@mziccard mziccard mentioned this pull request Sep 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv left review comments

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mziccard @coveralls @lesv @googlebot