Update datastore from v1beta3 to v1 #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change package names - Update LocalDatastoreHelper to use new emulator (cloud-datastore-emulator >= 1.2.0) - Enable all tests in DatastoreTest
googlebot
added
the
cla: yes
mziccard
added
the
do not merge
|
Putting this on hold until the emulator for |
mziccard
removed
the
do not merge
|
@lesv PTAL |
| @@ -66,16 +66,15 @@ | |||
| */ | |||
| public class LocalDatastoreHelper { | |||
| private static final Logger log = Logger.getLogger(LocalDatastoreHelper.class.getName()); | |||
| private static final String GCD_VERSION = "v1beta3"; | |||
| private static final String GCD_BUILD = "1.0.1"; | |||
| private static final String GCD_VERSION = "1.2.0"; | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM - my questions appear to be trivial. I would have expected to see a text version of the API change somewhere. GitHub's tools are a bit inadequate to answer my only question, did you miss something? What I've seen looks good. So, unless you think one of your answers would cause me to raise an object, it's ok to merge. |
|
LGTM |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 23, 2022
🤖 I have created a release *beep* *boop* --- ## [2.2.4](googleapis/java-automl@v2.2.3...v2.2.4) (2022-06-23) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#1167](googleapis/java-automl#1167)) ([fcc1036](googleapis/java-automl@fcc1036)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are:
This fixes #1165 and #1014