Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing field to Logging's HttpRequest class #1160

Merged
merged 1 commit into from
Aug 16, 2016
Merged

Add missing field to Logging's HttpRequest class #1160

merged 1 commit into from
Aug 16, 2016

Conversation

mziccard
Copy link
Contributor

This fixes #1042

@mziccard mziccard added the api: logging Issues related to the Cloud Logging API. label Aug 15, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 15, 2016
@mziccard
Copy link
Contributor Author

/cc @lesv

@lesv
Copy link
Contributor

lesv commented Aug 15, 2016

LGTM

@mziccard mziccard merged commit 36ba7c3 into googleapis:master Aug 16, 2016
github-actions bot pushed a commit that referenced this pull request Jun 21, 2022
@gcf-owl-bot
chore: skip formatting generated samples (#1456) (#1160)
e750f73 
Source-Link: googleapis/synthtool@625c20e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:58ccd4737212f64a7dd4b3063d447447acf71a2b9d409eab19fc7a00b18eadc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HttpRequest class in grpc-logging-type is missing serverIp
3 participants
@mziccard @lesv @googlebot