Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [iap] new module for iap #10905

Merged
merged 12 commits into from
May 31, 2024
Merged

feat: [iap] new module for iap #10905

merged 12 commits into from
May 31, 2024

Conversation

cloud-java-bot
Copy link
Collaborator

@cloud-java-bot cloud-java-bot commented May 31, 2024 •
edited by JoeWang1127
Loading

Generated by @JoeWang1127 via generate_new_client_hermetic_build.yaml

Command used:

python generation/new_client_hermetic_build/add-new-client-config.py add-new-client --api-shortname "iap" --name-pretty "Cloud Identity-Aware Proxy API" --api-description "Controls access to cloud applications running on Google Cloud Platform." --proto-path "google/cloud/iap/v1" --product-docs "https://cloud.google.com/iap"

b/343507706

@cloud-java-bot cloud-java-bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 31, 2024
@cloud-java-bot cloud-java-bot requested a review from a team as a code owner May 31, 2024 17:48
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 31, 2024
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented May 31, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 57 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

JoeWang1127
JoeWang1127 reviewed May 31, 2024
View reviewed changes
generation_config.yaml
product_documentation: https://cloud.google.com/iap
api_description: Controls access to cloud applications running on Google Cloud Platform.
client_documentation: https://cloud.google.com/java/docs/reference/google-cloud-iap/latest/overview
release_level: stable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I make the release level as stable

blakeli0
blakeli0 reviewed May 31, 2024
View reviewed changes
generation_config.yaml Outdated
cloud_api: true
GAPICs:
- proto_path: google/cloud/iap/v1
- proto_path: google/cloud/iap/v1beta1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you manually add v1beta1 here? I don't think we still have to generate v1beta1 since v1 is already here. Dotnet also don't have it generated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@JoeWang1127 JoeWang1127 force-pushed the new-library/iap-2aFWj branch from 7766263 to 54a996f Compare May 31, 2024 18:45
@JoeWang1127 JoeWang1127 requested a review from blakeli0 May 31, 2024 18:53
@JoeWang1127 JoeWang1127 enabled auto-merge (squash) May 31, 2024 19:26
@JoeWang1127 JoeWang1127 merged commit aa25967 into main May 31, 2024
31 checks passed
@JoeWang1127 JoeWang1127 deleted the new-library/iap-2aFWj branch May 31, 2024 19:47
@release-please release-please bot mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeWang1127 JoeWang1127 JoeWang1127 left review comments

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cloud-java-bot @blakeli0 @JoeWang1127