chore: fix repo-metadata.json api_ids to correctly identify the library coverage

[chingor13]

We are not associating these libraries correctly. The api_id is the hostname of the API and is used to identify the product/service.

[snippet-bot]

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

• Refresh this comment

[chingor13]

@blakeli0 From the generation action: ValueError: alloydb-connectors: api_shortname must not change when library_name remains the same.

[blakeli0]

@blakeli0 From the generation action: ValueError: alloydb-connectors: api_shortname must not change when library_name remains the same.

@JoeWang1127 is taking a look.

[JoeWang1127]

@chingor13 Why do you want to change api_shortname when the title said only api_id should change?

[chingor13]

Why do you want to change api_shortname when the title said only api_id should change?

api_shortname is supposed to be the main subdomain of the service's endpoint. api_shortname is the fallback for many systems to re-create the api_id (<api-shortname> + '.googleapis.com')

[JoeWang1127]

api_shortname is supposed to be the main subdomain of the service's endpoint. api_shortname is the fallback for many systems to re-create the api_id (<api-shortname> + '.googleapis.com')

We have a configuration comparator to determine which libraries are changed and changing api_shortname is a bit complex situation that I haven' design well.

For this PR, could you only change api_id? I need to think again how to support api_shortname change.

[chingor13]

For this PR, could you only change api_id? I need to think again how to support api_shortname change.

I left the library_name additions for the ones that will need to change later and it seems to have worked.

[chingor13]

These changes to the enable API URL look legit and correct to me.

[blakeli0]

Thanks Jeff! The change LGTM.
Just curious what drove you to make these changes? Are you working on a project to make .repo_metadata.json up to date? Or only because you noticed something wrong in our .repo_metadata.json files?