Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove old new_client and non-hermetic workflows/scripts #10783

Merged
merged 11 commits into from
May 13, 2024

Conversation

diegomarquezp
Copy link
Contributor

No description provided.

@diegomarquezp diegomarquezp requested a review from a team as a code owner May 3, 2024 17:22
@diegomarquezp diegomarquezp changed the title chore: remove old new_client chore: remove old new_client and non-hermetic workflos/scripts May 3, 2024
Not all the `new-client.py` arguments are available in the Github Action.
Please refer to
[this
section](https://github.com/googleapis/google-cloud-java/blob/main/generation/new_client_hermetic_build/README.md#advanced-options)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use local reference, starting with /?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@diegomarquezp diegomarquezp changed the title chore: remove old new_client and non-hermetic workflos/scripts chore: remove old new_client and non-hermetic workflows/scripts May 3, 2024
@diegomarquezp diegomarquezp enabled auto-merge (squash) May 9, 2024 20:29
@diegomarquezp diegomarquezp merged commit 1e8df46 into main May 13, 2024
32 checks passed
@diegomarquezp diegomarquezp deleted the delete-old-new-client branch May 13, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants