deps: update gapic generator java to 2.40.0 #10782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
blakeli0
previously approved these changes
May 3, 2024
blakeli0
reviewed
May 3, 2024
| @@ -24,7 +24,7 @@ | |||
| <dependencyManagement> | |||
| <dependencies> | |||
| <dependency> | |||
| <groupId>com.google.api-ads</groupId> | |||
| <groupId>com.google.api-ads.api.grpc</groupId> | |||
JoeWang1127
added
the
do not merge
JoeWang1127
removed
the
do not merge
blakeli0
reviewed
May 6, 2024
java-admanager/pom.xml
Outdated
| @@ -46,4 +46,4 @@ | |||
| <module>ad-manager-bom</module> | |||
| </modules> | |||
|
|
|||
| </project> | |||
| </project> | |||
There was a problem hiding this comment.
Can we revert this change as well? Also do we know where this change is from?
There was a problem hiding this comment.
This also comes from fix-poms.py.
pom.xml is not rendered from templates when updates so it's not clear to me how this indentation come.
There was a problem hiding this comment.
Reverted this change.
blakeli0
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.