Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update hermetic build docker volume usage #10770

Closed
wants to merge 14 commits into from
Closed

chore: update hermetic build docker volume usage #10770

wants to merge 14 commits into from

Conversation

diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented May 1, 2024 •
edited
Loading

Follow up of googleapis/sdk-platform-java#2615
The way we use the docker image changed with that pull request. Here we adapt to those changes.

@diegomarquezp diegomarquezp requested a review from a team as a code owner May 1, 2024 17:36
@diegomarquezp diegomarquezp marked this pull request as draft May 1, 2024 17:42
@diegomarquezp
Copy link
Contributor Author

Confirmed locally that generation/hermetic_library_generation.sh worked:

Library postprocessing finished successfully
Regenerating root pom.xml
Regenerating gapic-libraries-bom
Configuration diff:
28c28
<     personnel. - test2
---
>     personnel. -test2
[update-library-generation-docker-volume-usage e01a95db362] chore: generate libraries at Wed May  1 05:54:59 PM UTC 2024
 2 files changed, 3 insertions(+), 3 deletions(-)
Enumerating objects: 9, done.
Counting objects: 100% (9/9), done.
Delta compression using up to 24 threads
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 486 bytes | 486.00 KiB/s, done.
Total 5 (delta 4), reused 0 (delta 0), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (4/4), completed with 4 local objects.
To https://github.com/googleapis/google-cloud-java
   1d3caed6359..e01a95db362  update-library-generation-docker-volume-usage -> update-library-generation-docker-volume-usage

@diegomarquezp
Copy link
Contributor Author

From https://github.com/googleapis/google-cloud-java/actions/runs/8913106957/job/24477945575?pr=10770

docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "--baseline-generation-config-path=/workspace/baseline_generation_config.yaml": stat --baseline-generation-config-path=/workspace/baseline_generation_config.yaml: no such file or directory: unknown.

This is because 2.39.0 has a different interface. We need to wait until 2.40 is released to perform this change

@diegomarquezp diegomarquezp added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 1, 2024
@diegomarquezp diegomarquezp marked this pull request as ready for review May 1, 2024 18:20
JoeWang1127
JoeWang1127 reviewed May 1, 2024
View reviewed changes
generation/new_client_hermetic_build/README.md
--target-library-names=<library_name if specified; otherwise api_shortname>
docker run --rm -u $(id -u):$(id -g) -v $(pwd):/workspace --entrypoint \
python gcr.io/cloud-devrel-public-resources/java-library-generation:latest \
/src/generate_repo.py generate \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change this command to use entry_point.py because the cli in generate_repo.py will be removed soon.

blakeli0
blakeli0 reviewed May 1, 2024
View reviewed changes
generation/hermetic_library_generation.sh
-v /var/run/docker.sock:/var/run/docker.sock \
-e "RUNNING_IN_DOCKER=true" \
-e "REPO_BINDING_VOLUMES=-v ${repo_volumes}" \
-u "$(id -u):$(id -g)" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is the command enables us to modify/delete the docker generated files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, including ownership takeover performed by the container

@JoeWang1127
Copy link
Contributor

Included in #10758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeWang1127 JoeWang1127 JoeWang1127 left review comments

@blakeli0 blakeli0 blakeli0 left review comments

Assignees
No one assigned
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diegomarquezp @JoeWang1127 @blakeli0