Merge master into gcs-nio #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add options(namespace) method to LocalDatastoreHelper
…leapis#946) * Chain cause exception to service exception in translateAndThrow * Make exception constructors package scoped, better test coverage * Make exception classes final with public constructors
…pis#961) * Speed up builds by using an older version of maven-source-plugin (2.4) that doesn't have speed issues on ubuntu (as does 3.0.0) * Add comment to clarify maven-source-plugin downgrade
- Use Pattern and Matcher to parse URLs into identities - Make REGEX private in identity classes - Remove non-necessary javadoc - Change timestamps' type from String to Long - Change id's type from Long to String
- Add missing resource fields and remove non-needed ones - Add selector classes and selector options - Add dedicated option classes for aggregated options - Remove unnecessary "throws" from method signature - Add static function to handle 404 exceptions
- Add RegionOperationId, ZoneOperationId, GlobalOperationId classes - Add functional methods for operations to Compute's service and rpc classes - Add Operation class (with functional methods) - Add unit and integration tests
- Fix javadoc errors - Fix OperationId and Operation tests - Fix RegionOperationId equals
- Add Type enum to OperationId and type() getter - Replace instanceof with switch on type() - Add better javadoc to Operation - Remove final from Operation, make hashCode and equals final
- Add InstanceId, ForwardingRuleId and Global/RegionForwardingRuleId - Add AddressId, GlobalAddressId, RegionAddressId classes - Add functional methods for addresses to Compute's service and rpc classes - Add AddressInfo and Address classes - Add unit and integration tests
- Remove Zone/RegionResourceId - Make OperationId and AddressId abstract classes - Refactor javadoc - Add abstract setProjectId to AddressId and OperationId - Split testToAndFromUrl tests - Add better javadoc to identity classes
- Better class javadoc - Refactor setProjectId to avoid unnecessary casts - Make addressId setter public in Builder and subclasses - Add test to AddressTest for addressId setter
- Rename startPageToken option to pageToken - Add static factory methods from functional objects fromPb functions - Add tests for get methods that return null
…SHOT Update version to 0.2.3-SNAPSHOT
Add support for entities with incomplete key to Datastore.put
…apis#1045) * Update BigQuery dependency * Add support for BYTES data type
Release 0.2.3
…SHOT Update version to 0.2.4-SNAPSHOT
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
googlebot
added
the
cla: no
|
gcloud-java-contrib/gcloud-java-nio-examples/README.md:25 should read -0.2.4-SNAPSHOT instead of -0.2.1.-SNAPSHOT. Same for line 30. The release script updates this one, but of course this will only work once we're merged into master. |
|
gcloud-java-examples/README.md we'll want to update the instructions for edit: same for DnsExample. |
|
The CL's huge and I can't really check everything, but it looks to me like there's nothing else I'd change, everything else is good. |
jart
force-pushed
the
merge-master-into-gcs-nio
branch
from
3e06a58 to
6c47760
Compare
| private List<LicenseId> licenses; | ||
| private DeprecationStatus<ImageId> deprecationStatus; | ||
|
|
||
| BuilderImpl() {} |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks good to me. |
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
) * build(deps): bump certifi from 2022.9.24 to 2022.12.7 in /.kokoro Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.9.24 to 2022.12.7. - [Release notes](https://github.com/certifi/python-certifi/releases) - [Commits](certifi/python-certifi@2022.09.24...2022.12.07) --- updated-dependencies: - dependency-name: certifi dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @jean-philippe-martin
CC: @mziccard