Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dependency byte-buddy to enable mockStatic in Java 21 #10389

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

jaycee-li
Copy link
Contributor

byte-buddy is required for mocking static methods in java-vertexai. mockito-core 4.11.0 depends on byte-buddy 1.12.19, which is not compatible with Java 21. So we manually add byte-buddy 1.14.3 (lowest version that supports Java 21) to google-cloud-jar-parent.

@jaycee-li jaycee-li requested a review from a team as a code owner February 15, 2024 17:49
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scope is test. Library users won't see this. Good.

@jaycee-li jaycee-li enabled auto-merge (squash) February 15, 2024 18:33
@ZhenyiQ ZhenyiQ added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Feb 15, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 15, 2024
@alicejli alicejli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2024
@alicejli alicejli added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2024
@jaycee-li jaycee-li merged commit 184e04b into googleapis:main Feb 16, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants