What should Subscription.topic return when the topic is deleted

[mziccard]

When a topic is deleted its subscriptions are not. For such subscriptions the topic field assumes the special value "_deleted-topic_:. What should Subscription.topic() getter return in this case? I see two main options (there surely are more).

• Subscription.topic() returns null
• Subscription.topic() returns TopicId.of("_deleted-topic_")

Regardless, this should be properly documented.
/cc @aozarov @eschapira to hear your thoughts

[eschapira]

I suggest to have a singleton and add the method isDeleted to topic.
Returning null is semantically correct, but nulls are problematic and can
crash the app inadvertently.

The next question is what to do when any method is called on the deleted
topic. You can throw NotFound on the singleton, or just call the server,
but the error will be less intuitive.
On May 6, 2016 5:29 PM, "Marco Ziccardi" [email protected] wrote:

When a topic is deleted its subscriptions are not. For such subscriptions
the topic field assumes the special value "deleted-topic:. What should
Subscription.topic() getter return in this case? I see two main options
(there surely are more).

• Subscription.topic() returns null
• Subscription.topic() returns TopicId.of("deleted-topic")

Regardless, this should be properly documented.
/cc @aozarov https://github.com/aozarov @eschapira
https://github.com/eschapira to hear your thoughts

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#991

[mziccard]

Closed with #984