Skip to content

Commit

Permalink
Fix code review issues
Browse files Browse the repository at this point in the history
  • Loading branch information
yihanzhen committed Jun 18, 2018
1 parent 82efad2 commit f474b6e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1179,11 +1179,7 @@ CloseableIterator<PartialResultSet> startStream(@Nullable ByteString resumeToken
: request.toBuilder().setResumeToken(resumeToken).build(),
stream.consumer(),
session.options);
// StreamController does not auto-request 1 message. Kick it off mannually
call.request(1);
if (prefetchChunks > 1) {
call.request(prefetchChunks - 1);
}
call.request(prefetchChunks);
stream.setCall(call);
return stream;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ public class GapicSpannerRpc implements SpannerRpc {
PathTemplate.create("projects/{project}");
private static final int MAX_MESSAGE_SIZE = 100 * 1024 * 1024;

// TODO(hzyi): change the stub names to be more intuitive
private final SpannerStub stub;
private final InstanceAdminStub instanceStub;
private final DatabaseAdminStub databaseStub;
Expand Down

0 comments on commit f474b6e

Please sign in to comment.