Skip to content

Commit

Permalink
fix: declaring test-scope artifact as runtime (#1014)
Browse files Browse the repository at this point in the history
Within this repository this dependency is only used in tests.
However, making this test scope causes undeclared dependencies
after the flatten-maven-plugin.

Similar to googleapis/java-pubsub#1239
  • Loading branch information
suztomo authored Aug 8, 2022
1 parent 8cca8b5 commit 6c47c65
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions java-aiplatform/google-cloud-aiplatform/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,17 @@
<groupId>com.google.api.grpc</groupId>
<artifactId>grpc-google-iam-v1</artifactId>
</dependency>
<dependency>
<groupId>com.google.code.gson</groupId>
<artifactId>gson</artifactId>
<!--
Within this repository this dependency is only used in tests. However,
making this test scope causes undeclared dependencies after the
flatten-maven-plugin.
https://github.com/mojohaus/flatten-maven-plugin/issues/185
-->
<scope>runtime</scope>
</dependency>

<!-- Test dependencies -->
<dependency>
Expand Down Expand Up @@ -108,11 +119,6 @@
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java-util</artifactId>
</dependency>
<dependency>
<groupId>com.google.code.gson</groupId>
<artifactId>gson</artifactId>
<scope>test</scope>
</dependency>
</dependencies>

<profiles>
Expand Down

0 comments on commit 6c47c65

Please sign in to comment.