Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-drop weak refs to parent modules and tag #9545

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Mar 11, 2024

Replay #6944 after giving 12+ months for importers to update to versions of cloud.google.com/go (>=v0.108.0) and cloud.google.com/go/compute (>=v1.13.0) that isolate the cloud.google.com/go/compute/metadata module.

Related to #6311

cc @codyoss @quartzmo

Replay googleapis#6944 after giving 12+ months for importers to update to versions of
cloud.google.com/go (>=v0.108.0) and cloud.google.com/go/compute (>=v1.13.0)
that isolate the cloud.google.com/go/compute/metadata module.
@codyoss codyoss added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Mar 11, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 11, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit f0a2781 into googleapis:main Mar 11, 2024
11 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Mar 11, 2024
@sagikazarmark
Copy link

When can we expect a release with these changes?

@codyoss
Copy link
Member

codyoss commented Apr 9, 2024

Thanks for the reminder here. We will get something out next week!

gopherbot pushed a commit to golang/oauth2 that referenced this pull request Apr 17, 2024
Related #615
Related googleapis/google-cloud-go#9545

Change-Id: I762dc53c61204ec5103336dab6358b9b4d1337d4
GitHub-Last-Rev: 439c393
GitHub-Pull-Request: #719
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/579495
Reviewed-by: Cody Oss <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Cody Oss <[email protected]>
Reviewed-by: Jordan Liggitt <[email protected]>
jbrichetto pushed a commit to openly-engineering/oauth2 that referenced this pull request May 22, 2024
Related golang#615
Related googleapis/google-cloud-go#9545

Change-Id: I762dc53c61204ec5103336dab6358b9b4d1337d4
GitHub-Last-Rev: 439c393
GitHub-Pull-Request: golang#719
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/579495
Reviewed-by: Cody Oss <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Cody Oss <[email protected]>
Reviewed-by: Jordan Liggitt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants