Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spanner): use json.Number for decoding unknown values from spanner #9054

Merged
merged 16 commits into from
Dec 14, 2023
Merged
Prev Previous commit
Next Next commit
fix go vet
rahul2393 committed Dec 13, 2023
commit 430c29fc4c389568861a21417a0c60b5546e5d7c
6 changes: 3 additions & 3 deletions spanner/integration_test.go
Original file line number Diff line number Diff line change
@@ -2179,8 +2179,8 @@ func TestIntegration_BasicTypes(t *testing.T) {
c, err = createClient(ctx, dbPath, ClientConfig{UseNumber: true, SessionPoolConfig: DefaultSessionPoolConfig})
require.NoError(t, err)
defer c.Close()
enableJsonProviderNumberConfig(true)
defer enableJsonProviderNumberConfig(false)
enableJSONProviderNumberConfig(true)
defer enableJSONProviderNumberConfig(false)
}
// Write rows into table first using DML.
statements := make([]Statement, 0)
@@ -5549,7 +5549,7 @@ func checkCommonTagsGFELatency(t *testing.T, m map[tag.Key]string) {
}

// helper method to enable json provider with useNumber flag, only for testing.
func enableJsonProviderNumberConfig(useNumber bool) {
func enableJSONProviderNumberConfig(useNumber bool) {
jsonProvider = jsoniter.Config{
EscapeHTML: true,
SortMapKeys: true, // Sort map keys to ensure deterministic output, to be consistent with encoding.