Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(pubsub): add retry guard to ordering key test #8765

Merged
merged 2 commits into from
Oct 31, 2023
Merged

test(pubsub): add retry guard to ordering key test #8765

merged 2 commits into from
Oct 31, 2023

Conversation

hongalex
Copy link
Member

@hongalex hongalex commented Oct 24, 2023 •
edited
Loading

Fixes #8702

Notes for reviewer: no significant logic was changed. Wrapping inside testutil.Retry causes indentation and renaming from testing.T -> testutil.R, which Github diff doesn't like.

@hongalex hongalex requested review from shollyman and a team as code owners October 24, 2023 20:58
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the Pub/Sub API. labels Oct 24, 2023
@hongalex hongalex enabled auto-merge (squash) October 31, 2023 17:59
@hongalex hongalex merged commit 858254b into googleapis:main Oct 31, 2023
@hongalex hongalex deleted the retry-ordering-keys-json branch October 31, 2023 20:16
bhshkh pushed a commit that referenced this pull request Nov 3, 2023
@hongalex @bhshkh
test(pubsub): add retry guard to ordering key test (#8765)
db4bb7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pubsub: TestIntegration_OrderedKeys_JSON failed
2 participants
@hongalex @shollyman