test(pubsub): dedupe by message data in ordering keys json test #8526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
noahdietz
approved these changes
Sep 11, 2023
pubsub/integration_test.go
Outdated
| _, err := r.Get(ctx) | ||
| if err != nil { | ||
| // Can't fail inside goroutine, so just log the error | ||
| log.Printf("publish error for message(%s): %v", msg, err) |
There was a problem hiding this comment.
Might be worth just using the test logger:
Suggested change
| log.Printf("publish error for message(%s): %v", msg, err) | |
| t.Logf("publish error for message(%s): %v", msg, err) |
pubsub/integration_test.go
Outdated
Comment on lines
23
to
24
| "io/ioutil" | ||
| "log" |
There was a problem hiding this comment.
Suggested change
| "io/ioutil" | |
| "log" | |
| "io/ioutil" |
Goes with the other change suggested, but feel free to do them in your own single commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8520
See comments in above issue for how this PR fixes this test