Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(bigquery): improve RowIterator docs and out of process pagination with Storage API #8419

Merged
merged 5 commits into from
Aug 15, 2023
Merged

docs(bigquery): improve RowIterator docs and out of process pagination with Storage API #8419

merged 5 commits into from
Aug 15, 2023

Conversation

alvarowolfx
Copy link
Contributor

@alvarowolfx alvarowolfx commented Aug 15, 2023 •
edited
Loading

Fixes #7285, fixes #8373, fixes #8173

@alvarowolfx alvarowolfx requested a review from shollyman August 15, 2023 15:35
@alvarowolfx alvarowolfx requested review from a team as code owners August 15, 2023 15:35
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the BigQuery API. labels Aug 15, 2023
shollyman
shollyman approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we selectively accelerate some iterators and not others with the enhanced storage integration? If so, may be worth calling out how to check if the iterator is backed by the read API.

@alvarowolfx
Copy link
Contributor Author

Do we selectively accelerate some iterators and not others with the enhanced storage integration? If so, may be worth calling out how to check if the iterator is backed by the read API.

I added a reference to the IsAccelerated method on the RowIterator to check if the given iterator is being backend by Storage API.

@alvarowolfx alvarowolfx added the automerge Merge the pull request once unit tests and other checks pass. label Aug 15, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 40f8f80 into googleapis:main Aug 15, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 15, 2023
@release-please release-please bot mentioned this pull request Aug 15, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 17, 2023
@release-please
chore(main): release bigquery 1.54.0 (#8326)
2a1455d 
🤖 I have created a release *beep* *boop*
---


## [1.54.0](https://togithub.com/googleapis/google-cloud-go/compare/bigquery/v1.53.0...bigquery/v1.54.0) (2023-08-17)


### Features

* **bigquery/biglake:** Start generating apiv1 and apiv1alpha1 ([#8433](https://togithub.com/googleapis/google-cloud-go/issues/8433)) ([916f779](https://togithub.com/googleapis/google-cloud-go/commit/916f779a3513b2532d2e0fbd15bfd381ae3efeb5))
* **bigquery/datatransfer:** Add EncryptionConfiguration to TransferConfig ([e3f8c89](https://togithub.com/googleapis/google-cloud-go/commit/e3f8c89429a207c05fee36d5d93efe76f9e29efe))
* **bigquery/storage/managedwriter:** Refine connection metrics ([#8324](https://togithub.com/googleapis/google-cloud-go/issues/8324)) ([54fcf36](https://togithub.com/googleapis/google-cloud-go/commit/54fcf36fe7e26d6e3d11deec19f56e92ceb87d34))
* **bigquery/storage:** Add beta2 deprecation message ([b3dbdde](https://togithub.com/googleapis/google-cloud-go/commit/b3dbdde48ddfa215c3c3bb110e0051fd8158f451))
* **bigquery/storage:** Add default_missing_value_interpretation field; indicate KMS_SERVICE_ERROR is retryable ([b3dbdde](https://togithub.com/googleapis/google-cloud-go/commit/b3dbdde48ddfa215c3c3bb110e0051fd8158f451))
* **bigquery:** Add ProjectID to JobIDConfig ([#8405](https://togithub.com/googleapis/google-cloud-go/issues/8405)) ([7fafd80](https://togithub.com/googleapis/google-cloud-go/commit/7fafd805327a0734e1602a597c2ded09a860f405))


### Bug Fixes

* **bigquery/datapolicies:** Sync the new PredefinedEpxression types to the client library ([fcb41cc](https://togithub.com/googleapis/google-cloud-go/commit/fcb41cc1d2435452ee78314c1b0362e3f21ae637))
* **bigquery:** Use JobFromProject for storage iterator ([#8372](https://togithub.com/googleapis/google-cloud-go/issues/8372)) ([bfbf18c](https://togithub.com/googleapis/google-cloud-go/commit/bfbf18cb373cd6a88a22eec8db7033f6678df755))


### Documentation

* **bigquery/storage/managedwriter:** Augment context usage in package docs ([#8334](https://togithub.com/googleapis/google-cloud-go/issues/8334)) ([b30a7f4](https://togithub.com/googleapis/google-cloud-go/commit/b30a7f4a520c358eb71e1378b98e7413c2ea7f81))
* **bigquery:** Improve RowIterator docs and out of process pagination with Storage API ([#8419](https://togithub.com/googleapis/google-cloud-go/issues/8419)) ([40f8f80](https://togithub.com/googleapis/google-cloud-go/commit/40f8f809d9ad1e6d2d0f6207cdf38428c306cb66))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@derekperkins derekperkins mentioned this pull request Aug 18, 2023
Closed
This was referenced Aug 22, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
2 participants
@alvarowolfx @shollyman