feat(bigtable): Support last_scanned_row_key in emulator #8343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveniemitz
requested review from
igorbernstein2,
bhshkh and
a team
as code owners
product-auto-label
bot
added
size: m
steveniemitz
force-pushed
the
bt-lsr-emu
branch
2 times, most recently
from
7f6285b to
559a533
Compare
mutianf
approved these changes
Jul 28, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
This adds support for last_scanned_row_key to the bigtable client, as well as sending feature flags to the server. note: this depends on #8343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the bigtable emulator to simulate sending back last_scanned_row_key responses if the client requests them (via a feature flag). We use rows that don't match the incoming filter here, which is a good simulation of what the server would do.