Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(storage): add retry to ACL tests that rely on eventual consistency #8313

Merged
merged 4 commits into from
Jul 26, 2023
Merged

test(storage): add retry to ACL tests that rely on eventual consistency #8313

merged 4 commits into from
Jul 26, 2023

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Jul 21, 2023 •
edited
Loading

This adds retry in the PredefinedACLs integration test that relies on eventual consistency

Fixes #7653

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the Cloud Storage API. labels Jul 21, 2023
tritone
tritone approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@cojenco cojenco marked this pull request as ready for review July 26, 2023 20:42
@cojenco cojenco requested review from a team as code owners July 26, 2023 20:42
@cojenco cojenco added the automerge Merge the pull request once unit tests and other checks pass. label Jul 26, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 954fb0b into googleapis:main Jul 26, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage: TestIntegration_PredefinedACLs failed
2 participants
@cojenco @tritone