fix(httpreplay): add ignore-header flag, fix tests #7865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 3, 2023
🤖 I have created a release *beep* *boop* --- ## [0.110.1](https://togithub.com/googleapis/google-cloud-go/compare/v0.110.0...v0.110.1) (2023-05-03) ### Bug Fixes * **httpreplay:** Add ignore-header flag, fix tests ([#7865](https://togithub.com/googleapis/google-cloud-go/issues/7865)) ([1829706](https://togithub.com/googleapis/google-cloud-go/commit/1829706c5ade36cc786b2e6780fda5e7302f965b)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new
httpreplay/cmd/httprflagignore-headerwhich can be provided multiple times and which configures theignoreHeadersproperty of theProxycreated.Fixes the timeout issues in the below integration test failures created by the GCS retry headers forcing request cache misses in the recording proxy, resulting in a retriable error being emitted and retrying forever. Utilizes the
ignore-headerflag orRemoveRequestHeader/IgnoreHeaderhelpers as needed. To prevent infinite retries in the future, I also added a 10 second timeout to the GCS requests made in the tests.Fixes #7818
Fixes #7817