-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pubsublite): enforce minimum publisher and subscriber timeout of 2 minutes #7746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
Pull request size is medium.
api: pubsublite
Issues related to the Pub/Sub Lite API.
labels
Apr 13, 2023
hongalex
approved these changes
Apr 19, 2023
codyoss
reviewed
Apr 20, 2023
codyoss
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
tmdiep
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Apr 21, 2023
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Apr 21, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
🤖 I have created a release *beep* *boop* --- ## [1.7.1](https://togithub.com/googleapis/google-cloud-go/compare/pubsublite/v1.7.0...pubsublite/v1.7.1) (2023-04-21) ### Bug Fixes * **pubsublite:** Enforce minimum publisher and subscriber timeout of 2 minutes ([#7746](https://togithub.com/googleapis/google-cloud-go/issues/7746)) ([89a9b0b](https://togithub.com/googleapis/google-cloud-go/commit/89a9b0b40fd2d4b1cf256b6c90a2108a62c44bed)) ### Documentation * **pubsublite:** Example for configuring earlier OAuth token refresh ([#7745](https://togithub.com/googleapis/google-cloud-go/issues/7745)) ([290d637](https://togithub.com/googleapis/google-cloud-go/commit/290d637e05401340677b77daa504ddc975fc0901)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low timeout values are harmful, as they cause the publisher or subscriber client to terminate if exceeded, which then causes confusion. If a value less than 2 minutes is set, it will be clamped to 2 minutes and a warning will be logged. In the future, a value less than 2 minutes will result in an error.