-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bigquery/storage/managedwriter): fix option propagation #7669
Merged
shollyman
merged 4 commits into
googleapis:main
from
shollyman:fix-settings-propagation
Mar 31, 2023
Merged
fix(bigquery/storage/managedwriter): fix option propagation #7669
shollyman
merged 4 commits into
googleapis:main
from
shollyman:fix-settings-propagation
Mar 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for the backend to more efficient route traffic. Normally we'd extract this from the request, but location is not part of the write identifier.
With recent multiplex refactors, call options were not being propagated properly for non-multiplex writers as we formerly created a pool-per-writer. This allows the router to build exclusive connections using the writers settings, namely overrides to flow control and call options propagated to the underlying AppendRows RPC. Towards: googleapis#7103
product-auto-label
bot
added
size: m
Pull request size is medium.
api: bigquery
Issues related to the BigQuery API.
labels
Mar 31, 2023
shollyman
changed the title
fix(bigquery/storage/managedwriter): fix option propagation
fix(bigquery/storage/managedwriter): fix option propagation
Mar 31, 2023
alvarowolfx
approved these changes
Mar 31, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 3, 2023
🤖 I have created a release *beep* *boop* --- ## [1.50.0](https://togithub.com/googleapis/google-cloud-go/compare/bigquery/v1.49.0...bigquery/v1.50.0) (2023-04-03) ### Features * **bigquery/connection:** Add spark connection properties type ([#7570](https://togithub.com/googleapis/google-cloud-go/issues/7570)) ([499b489](https://togithub.com/googleapis/google-cloud-go/commit/499b489d8d6bc8db203c864db97f1462bbeff3d2)) * **bigquery/migration:** Add request_source field and update formatting ([#7586](https://togithub.com/googleapis/google-cloud-go/issues/7586)) ([c967961](https://togithub.com/googleapis/google-cloud-go/commit/c967961ed95750e173af0193ec8d0974471f43ff)) * **bigquery/reservation:** Add edition/autoscale related fields ([#7608](https://togithub.com/googleapis/google-cloud-go/issues/7608)) ([2b7bb66](https://togithub.com/googleapis/google-cloud-go/commit/2b7bb662eb00671b8ee933766f4254f897131a7c)) * **bigquery/storage/managedwriter:** Decouple connections and writers ([#7314](https://togithub.com/googleapis/google-cloud-go/issues/7314)) ([7d085b4](https://togithub.com/googleapis/google-cloud-go/commit/7d085b4b25a29ff1a81164409fc68b8bcb5eacc4)) * **bigquery/storage/managedwriter:** Introduce location routing header ([#7663](https://togithub.com/googleapis/google-cloud-go/issues/7663)) ([cf06802](https://togithub.com/googleapis/google-cloud-go/commit/cf068024f1066ee391191066039d7ba2668dd3f4)) ### Bug Fixes * **bigquery/storage/managedwriter:** Fix option propagation ([#7669](https://togithub.com/googleapis/google-cloud-go/issues/7669)) ([f684e16](https://togithub.com/googleapis/google-cloud-go/commit/f684e1610c51311c597763b5d1447c178173940a)) ### Documentation * **bigquery/reservation:** Mention that some fields are deprecated ([597ea0f](https://togithub.com/googleapis/google-cloud-go/commit/597ea0fe09bcea04e884dffe78add850edb2120d)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This was referenced Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With recent refactors, call options were not being propagated properly for non-multiplex writers.
We initially created a pool-per-writer and thus resolved these differences via the settings on the pool,
but have improved this situation to have a pool-per-region. The custom settings were being silently
dropped on the floor. The impacted settings were the connection-related options, namely flow control limits and custom call options.
With this change we allow for default settings on the pool, and custom settings on a connection. In usage, this
is only leveraged for non-multiplexed connections as we have 1:1 relationships between connections and writers.
Towards: #7103