Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): add directed reads feature #7668

Merged
merged 32 commits into from
Jan 8, 2024
Merged

feat(spanner): add directed reads feature #7668

merged 32 commits into from
Jan 8, 2024

Conversation

harshachinta
Copy link
Contributor

@harshachinta harshachinta commented Mar 31, 2023 •
edited
Loading

[DO NOT MERGE]
This PR adds code changes for Directed Reads.

@harshachinta harshachinta requested a review from rahul2393 March 31, 2023 12:13
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: spanner Issues related to the Spanner API. labels Mar 31, 2023
@harshachinta harshachinta marked this pull request as ready for review April 6, 2023 10:07
@harshachinta harshachinta requested review from a team as code owners April 6, 2023 10:07
asthamohta
asthamohta reviewed Apr 7, 2023
View reviewed changes
spanner/transaction.go Outdated Show resolved Hide resolved
asthamohta
asthamohta reviewed Apr 7, 2023
View reviewed changes
spanner/transaction.go Outdated Show resolved Hide resolved
asthamohta
asthamohta reviewed Apr 7, 2023
View reviewed changes
spanner/transaction.go Outdated Show resolved Hide resolved
@harshachinta harshachinta requested a review from asthamohta April 7, 2023 15:55
@harshachinta harshachinta added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 7, 2023
@asthamohta
Copy link
Contributor

LGTM.

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2023
@product-auto-label product-auto-label bot added the stale: extraold Pull request is critically old and needs prioritization. label Sep 17, 2023
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Nov 2, 2023
@harshachinta harshachinta removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 8, 2024
@harshachinta harshachinta merged commit a42604a into googleapis:main Jan 8, 2024
10 checks passed
@release-please release-please bot mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asthamohta asthamohta asthamohta approved these changes

@rahul2393 rahul2393 rahul2393 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. size: l Pull request size is large. stale: extraold Pull request is critically old and needs prioritization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshachinta @asthamohta @rahul2393 @kokoro-team