Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch from syntax to presence checks #7532

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

shollyman
Copy link
Contributor

Added in response to internal cl/514925348, which is trying to deprecate syntax version checking in favor of capability checks.

Added in response to cl/514925348, which is trying to deprecate
syntax version checking in favor of capability checks.
@shollyman shollyman requested review from alvarowolfx and a team March 9, 2023 23:08
@shollyman shollyman requested a review from a team as a code owner March 9, 2023 23:08
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 9, 2023
Copy link
Contributor

@alvarowolfx alvarowolfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shollyman shollyman added the automerge Merge the pull request once unit tests and other checks pass. label Mar 9, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1e821bd into googleapis:main Mar 9, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 9, 2023
@shollyman shollyman deleted the i-feel-a-presence branch March 9, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants