Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(compute): remove TestCapitalLetter #6908

Merged
merged 3 commits into from
Oct 24, 2022
Merged

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Oct 21, 2022

This test has been flaky for a long time. If we want something like this test in the future I think it needs to be re-structured to be successful. For now we will remove it as it is not providing value as is and since writing there are now many tests in our samples that should cover these types of use-cases.

Fixes: #5988

This test has been flaky for a long time. If we want something like
this test in the future I think it needs to be re-structured to be
successful. For now we will remove it as it is not providing value
as is and since writing there are now many tests in our samples that
should cover these types of use-cases.

Fixes: googleapis#5988
@codyoss codyoss requested a review from a team as a code owner October 21, 2022 15:57
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: compute Issues related to the Compute Engine API. labels Oct 21, 2022
@codyoss codyoss merged commit c6b704a into googleapis:main Oct 24, 2022
@codyoss codyoss deleted the rm-smoke-test branch October 24, 2022 15:18
kimihrr pushed a commit to kimihrr/google-cloud-go-kimia that referenced this pull request Oct 25, 2022
This test has been flaky for a long time. If we want something like this test in the future I think it needs to be re-structured to be successful. For now we will remove it as it is not providing value as is and since writing there are now many tests in our samples that should cover these types of use-cases.

Fixes: googleapis#5988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compute/apiv1: TestCapitalLetter failed
2 participants