Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner/spansql): support fine-grained access control DDL syntax #6691

Merged
merged 16 commits into from
Mar 6, 2023

Conversation

nktks
Copy link
Contributor

@nktks nktks commented Sep 18, 2022

This PR supports fine-grained access control DDL syntax parsing.

  • CREATE ROLE
  • DROP ROLE
  • GRANT
  • REVOKE

@nktks nktks requested review from a team as code owners September 18, 2022 07:00
@google-cla
Copy link

google-cla bot commented Sep 18, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Sep 18, 2022
@nktks nktks changed the title feat(spanner/spansql)support role clauses feat(spanner/spannersql): support fine-grained access control DDL syntax Sep 18, 2022
@nktks nktks changed the title feat(spanner/spannersql): support fine-grained access control DDL syntax feat(spanner/spansql): support fine-grained access control DDL syntax Sep 18, 2022
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Sep 18, 2022
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2022
@rahul2393
Copy link
Contributor

Thanks @nktks for this, please fix the conflicts.

@nktks
Copy link
Contributor Author

nktks commented Sep 19, 2022

@rahul2393 Thank you! I fixed conflict and following function name change.

@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Oct 18, 2022
@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Nov 17, 2022
@toga4
Copy link
Contributor

toga4 commented Mar 6, 2023

Are there any obstacles other than conflicts in proceeding with this PR?
We are waiting for this PR to be merged.

@nktks
Copy link
Contributor Author

nktks commented Mar 6, 2023

@toga4 Thanks for your reminding.

I fixed conflicts and modified code not to change exist func name (like parseCommaList, parseTableOrIndexOrColumnName, parseColumnNameList) for avoiding compile error when other PR's changes include these function.

@rahul2393 Could you please take a look this PR?

Thank you!

@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2023
@rahul2393 rahul2393 merged commit a7edf6b into googleapis:main Mar 6, 2023
@nktks nktks deleted the feature/spansql-role branch March 6, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. size: l Pull request size is large. stale: extraold Pull request is critically old and needs prioritization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants