feat(pubsub): support bigquery subscriptions #6119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
kamalaboulhosn
requested changes
Jun 7, 2022
| @@ -210,14 +210,90 @@ func (oidcToken *OIDCToken) toProto() *pb.PushConfig_OidcToken_ { | |||
| } | |||
| } | |||
|
|
|||
| // BigQueryConfigState denotes the possible states for a BigQuery Subscription. | |||
| type BigQueryConfigState int | |||
There was a problem hiding this comment.
We added a SubscriptionState field as well as part of this feature. Should we add that here as well?
There was a problem hiding this comment.
Added. I also made the fake return Active for both Subscription/BigQueryConfigState by default.
…ud-go into feat-bigquery-config
hongalex
added
the
do not merge
kamalaboulhosn
approved these changes
Jun 22, 2022
hongalex
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for bigquery subscriptions, including in the fake
Do not merge until feature is GA
Closes #6118