Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): add retry metrics for Reader #6056

Merged
merged 2 commits into from
May 19, 2022

Conversation

tritone
Copy link
Contributor

@tritone tritone commented May 19, 2022

With this change, the Reader will also send the x-goog-api-client
retry fields with each request.

Invocation ID will be different if a download is interrupted
partway through and a new ranged request is made. Discussed this
internally and this is expected.

With this change, the Reader will also send the x-goog-api-client
retry fields with each request.

Invocation ID will be different if a download is interrupted
partway through and a new ranged request is made. Discussed this
internally and this is expected.
@tritone tritone requested review from a team as code owners May 19, 2022 14:17
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the Cloud Storage API. labels May 19, 2022
Copy link

@ddelgrosso1 ddelgrosso1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tritone tritone enabled auto-merge (squash) May 19, 2022 15:26
@codyoss codyoss disabled auto-merge May 19, 2022 15:33
@codyoss codyoss merged commit 1a21711 into googleapis:main May 19, 2022
@tritone tritone deleted the reader-retry-metric branch May 19, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants