feat(bigtable): add GC policy to FamilyInfo.

[hoangpham95]

We need the proto of GC policy exposed so that Terraform can read max_version and max_age from the policy, instead of a fully parsed string. Fix #6122.

[tritone]

Have you considered just adding the fields you need directly on this object, rather than exposing the whole proto?

In general we try to avoid exposing proto-types directly via the manual clients. Though, I see a few cases already where they are in this library, so I'll just have this as a question/suggestion rather than being a purist about it.

[hoangpham95]

We're interested in recursively iterate through this proto to generate a valid JSON field for Terraform. The one we're interested in is the Rule object in *btapb.GcRule, but the type of that object is not exported, so I opt in to pass the entire proto here.

[telpirion]

I agree with @tritone. We typically try to provide a veneer over proto message types.

[hoangpham95]

I see, so how about adding a new struct in the bigtable client and a parser function to convert the proto to the new struct, and pass that struct back from the admin?

[telpirion]

I agree with @tritone. We typically try to provide a veneer over proto message types.

[telpirion]

Does this have a corresponding Issue?

Clicked the wrong button

[tritone]

Two more small comments, otherwise LGTM. @telpirion must approve though.

Revoking approval

[telpirion]

It looks like something similar to this feature is already available in the Java BT client, so it's reasonable to include here.

[gcf-merge-on-green]

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.