feat(pubsub): deprecate synchronous mode #5910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
…ex/google-cloud-go into fix-pubsub-deprecated-synchronous
kamalaboulhosn
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go Pub/Sub library is the only official Pub/Sub library that offers
Synchronousmode, which switches the underlying poll mechanism forReceiveto the unary Pull instead of the streaming StreamingPull API. This was significant in the past since StreamingPull had the limitation of "overpulling" from the server, since we didn't have server side flow control. Now that server side flow control has been out for a while, we are recommending to users to always use the more performant StreamingPull (or the default Synchronous = false) and will be removingSynchronousin a later version of the library. There is a plan to expose thePullmethod as a separate method later onceSynchronousis fully removed for those who do not wish to use the streaming API.Also fixes #5012 by updating the synchronous mode documentation.