Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bigtable): abbreviate instance and cluster names to < 32 chars #4973

Merged
merged 1 commit into from
Oct 11, 2021
Merged

test(bigtable): abbreviate instance and cluster names to < 32 chars #4973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bigtable/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2427,7 +2427,7 @@ func TestIntegration_AdminBackup(t *testing.T) {
t.Fatalf("NewInstanceAdminClient: %v", err)
}
defer iAdminClient.Close()
uniqueID := make([]byte, 8)
uniqueID := make([]byte, 4)
_, err = rand.Read(uniqueID)
diffInstance := fmt.Sprintf("%s-d-%x", testEnv.Config().Instance, uniqueID)
diffCluster := sourceCluster + "-d"
Expand Down
8 changes: 4 additions & 4 deletions internal/kokoro/continuous.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ export GCLOUD_TESTS_GOLANG_KEYRING=projects/dulcet-port-762/locations/us/keyRing
export GCLOUD_TESTS_GOLANG_PROFILER_ZONE="us-west1-b"

# Bigtable integration tests expect an existing instance and cluster
# ❯ cbt createinstance gcloud-bt-it-tests-instance gcloud-bt-it-tests-instance \
# gcloud-bt-it-tests-cluster us-west1-b 1 SSD
# ❯ cbt createinstance gc-bt-it-instance gc-bt-it-instance \
# gc-bt-it-cluster us-west1-b 1 SSD
export GCLOUD_TESTS_BIGTABLE_KEYRING=projects/dulcet-port-762/locations/us-central1/keyRings/go-integration-test
export GCLOUD_TESTS_BIGTABLE_CLUSTER="gcloud-bt-it-tests-cluster"
export GCLOUD_TESTS_BIGTABLE_INSTANCE="gcloud-bt-it-tests-instance"
export GCLOUD_TESTS_BIGTABLE_CLUSTER="gc-bt-it-cluster"
export GCLOUD_TESTS_BIGTABLE_INSTANCE="gc-bt-it-instance"

# Fail on any error
set -eo pipefail
Expand Down