Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spanner): mark SessionPoolConfig.MaxBurst deprecated #4115

Merged
merged 4 commits into from
May 19, 2021
Merged

fix(spanner): mark SessionPoolConfig.MaxBurst deprecated #4115

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90b1adb
fix(spanner): mark SessionPoolConfig.MaxBurst deprecated
hengfengli May 18, 2021
75371bf
Update the comment.
hengfengli May 18, 2021
69ec250
Update the comment.
hengfengli May 19, 2021
0969ea6
Merge branch 'master' into mark-max-burst-unused
hengfengli May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions spanner/session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,14 @@ type SessionPoolConfig struct {

// MaxBurst is the maximum number of concurrent session creation requests.
//
// Deprecated: MaxBurst exists for historical compatibility and should not
// be used. MaxBurst was used to limit the number of sessions that the
// session pool could create within a time frame. This was an early safety
// valve to prevent a client from overwhelming the backend if a large number
// of sessions was suddenly needed. The session pool would then pause the
// creation of sessions for a while. Such a pause is no longer needed and
// the implementation has been removed from the pool.
//
// Defaults to 10.
MaxBurst uint64

Expand Down