Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): generate GAPIC under internal subdir #4018

Merged
merged 11 commits into from
Jun 29, 2021
Merged

chore(storage): generate GAPIC under internal subdir #4018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7e65b5d
feat: add GCS GAPIC PoC
noahdietz Apr 29, 2021
9eb7d7a
regen and reformat
noahdietz Jun 15, 2021
55f8396
fix config rebase mistake
noahdietz Jun 15, 2021
55c4787
update with ggg v0.21.0
noahdietz Jun 24, 2021
24bfc2a
Merge branch 'master' into gcs-gapic-poc
noahdietz Jun 24, 2021
9f682c0
fix microgen config test
noahdietz Jun 24, 2021
f5ef8cc
Merge branch 'gcs-gapic-poc' of https://github.com/noahdietz/google-c…
noahdietz Jun 24, 2021
e992c2f
fix config test
noahdietz Jun 24, 2021
ad360df
Merge branch 'master' into gcs-gapic-poc
noahdietz Jun 24, 2021
e22e47f
Merge branch 'master' into gcs-gapic-poc
noahdietz Jun 28, 2021
9ac502d
Merge branch 'master' into gcs-gapic-poc
noahdietz Jun 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions internal/gapicgen/generator/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1222,4 +1222,12 @@ var microgenGapicConfigs = []*microgenConfig{
// GA after 2021/06/10
releaseLevel: "beta",
},
{
inputDirectoryPath: "google/storage/v1",
pkg: "storage",
importPath: "cloud.google.com/go/storage/internal/apiv1",
gRPCServiceConfigPath: "google/storage/v1/storage_grpc_service_config.json",
apiServiceConfigPath: "google/storage/v1/storage_v1.yaml",
releaseLevel: "alpha",
},
}
5 changes: 3 additions & 2 deletions internal/gapicgen/generator/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,9 @@ var apivExceptions = map[string]bool{
}

var packagePathExceptions = map[string]bool{
"cloud.google.com/go/longrunning/autogen": true,
"cloud.google.com/go/firestore/apiv1/admin": true,
"cloud.google.com/go/longrunning/autogen": true,
"cloud.google.com/go/firestore/apiv1/admin": true,
"cloud.google.com/go/storage/internal/apiv1": true,
}

// TestMicrogenConfigs validates config entries.
Expand Down
120 changes: 120 additions & 0 deletions storage/internal/apiv1/doc.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading