Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pubsublite): fix flaky TestAssignerHandlePartitionFailure #3671

Merged
merged 2 commits into from
Feb 4, 2021

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Feb 4, 2021

Checks only the final error to ensure the test is deterministic.

Fixes #3667.

@tmdiep tmdiep requested review from a team as code owners February 4, 2021 03:50
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 4, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the Pub/Sub Lite API. label Feb 4, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmdiep tmdiep added the automerge Merge the pull request once unit tests and other checks pass. label Feb 4, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 38b944a into googleapis:master Feb 4, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 4, 2021
@tmdiep tmdiep deleted the flaky_partition_fail branch February 4, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the Pub/Sub Lite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pubsublite/internal/wire: TestAssignerHandlePartitionFailure failed
2 participants