Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): disable allow non-default credentials flag #11337

Merged
merged 2 commits into from
Dec 20, 2024
+2 −2
Merged

fix(storage): disable allow non-default credentials flag #11337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa0d293
fix(storage): disable allow non-default credentials flag
frankyn Dec 20, 2024
3777c99
skip test for direct connectivity
frankyn Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions storage/grpc_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,7 @@ func defaultGRPCOptions() []option.ClientOption {
// Only enable DirectPath when the emulator is not being targeted.
defaults = append(defaults,
internaloption.EnableDirectPath(true),
internaloption.EnableDirectPathXds(),
internaloption.AllowNonDefaultServiceAccount(true))
internaloption.EnableDirectPathXds())
}

return defaults
Expand Down
1 change: 1 addition & 0 deletions storage/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,7 @@ var readCases = []readCase{
// 3. DC not detected with dual region bucket in EUR4
// 4. DC not detected with regional bucket in EUROPE-WEST1
func TestIntegration_DetectDirectConnectivityInGCE(t *testing.T) {
t.Skip("Does not work in kokoro yet")
ctx := skipHTTP("grpc only test")
multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, bucket string, prefix string, client *Client) {
h := testHelper{t}
Expand Down
Loading