-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(shopping/merchant/products): Changed repeated flag of an existing field gtin
in message .google.shopping.merchant.products.v1beta.Attributes
#11247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…google.shopping.merchant.products.v1beta.Attributes` fix!: An existing field `gtin` is moved out of oneof in message `.google.shopping.merchant.products.v1beta.Attributes` docs: A comment for message `ProductInput` is changed docs: A comment for field `name` in message `.google.shopping.merchant.products.v1beta.ProductInput` is changed docs: A comment for field `name` in message `.google.shopping.merchant.products.v1beta.DeleteProductInputRequest` is changed docs: A comment for message `Product` is changed docs: A comment for field `name` in message `.google.shopping.merchant.products.v1beta.Product` is changed docs: A comment for field `name` in message `.google.shopping.merchant.products.v1beta.GetProductRequest` is changed docs: A comment for field `page_size` in message `.google.shopping.merchant.products.v1beta.ListProductsRequest` is changed docs: A comment for field `gtin` in message `.google.shopping.merchant.products.v1beta.Attributes` is changed docs: A comment for field `tax_category` in message `.google.shopping.merchant.products.v1beta.Attributes` is changed docs: A comment for field `min_handling_time` in message `.google.shopping.merchant.products.v1beta.Shipping` is changed docs: A comment for field `max_handling_time` in message `.google.shopping.merchant.products.v1beta.Shipping` is changed docs: A comment for field `min_transit_time` in message `.google.shopping.merchant.products.v1beta.Shipping` is changed docs: A comment for field `max_transit_time` in message `.google.shopping.merchant.products.v1beta.Shipping` is changed feat: A new field `member_price_effective_date` is added to message `.google.shopping.merchant.products.v1beta.LoyaltyProgram` feat: A new field `shipping_label` is added to message `.google.shopping.merchant.products.v1beta.LoyaltyProgram` PiperOrigin-RevId: 704281512 Source-Link: googleapis/googleapis@0f1beb9 Source-Link: googleapis/googleapis-gen@5429d7d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTQyOWQ3ZDQwYjI0OGFkMDM0N2U5MTZkZWZlZTE3YmE1MTE2NDAxMSJ9
trusted-contributions-gcf
bot
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Dec 9, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Dec 9, 2024
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Dec 9, 2024
gcf-owl-bot
bot
changed the title
fix!: Changed repeated flag of an existing field
fix(shopping/merchant/products)!: Changed repeated flag of an existing field Dec 9, 2024
gtin
in message .google.shopping.merchant.products.v1beta.Attributes
gtin
in message .google.shopping.merchant.products.v1beta.Attributes
trusted-contributions-gcf
bot
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Dec 9, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Dec 9, 2024
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Dec 9, 2024
codyoss
changed the title
fix(shopping/merchant/products)!: Changed repeated flag of an existing field
fix(shopping/merchant/products): Changed repeated flag of an existing field Dec 9, 2024
gtin
in message .google.shopping.merchant.products.v1beta.Attributes
gtin
in message .google.shopping.merchant.products.v1beta.Attributes
codyoss
approved these changes
Dec 9, 2024
Merged
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>automl: 1.14.3</summary> ## [1.14.3](https://togithub.com/googleapis/google-cloud-go/compare/automl/v1.14.2...automl/v1.14.3) (2024-12-11) ### Documentation * **automl:** Update io.proto to use markdown headings instead of HTML, remove some unused HTML from markdown ([#11234](https://togithub.com/googleapis/google-cloud-go/issues/11234)) ([0b3ab19](https://togithub.com/googleapis/google-cloud-go/commit/0b3ab19d38a5726b9e9db91fde933c4d7fe72fc8)) </details> <details><summary>batch: 1.11.4</summary> ## [1.11.4](https://togithub.com/googleapis/google-cloud-go/compare/batch/v1.11.3...batch/v1.11.4) (2024-12-11) ### Documentation * **batch:** Clarify options for logs ([38385d4](https://togithub.com/googleapis/google-cloud-go/commit/38385d441ba43e7bf6166ee5507a70e77c0b01f5)) * **batch:** Clarify the custom instance template needs to be in the same project ([38385d4](https://togithub.com/googleapis/google-cloud-go/commit/38385d441ba43e7bf6166ee5507a70e77c0b01f5)) </details> <details><summary>chat: 0.9.0</summary> ## [0.9.0](https://togithub.com/googleapis/google-cloud-go/compare/chat/v0.8.0...chat/v0.9.0) (2024-12-11) ### Features * **chat:** Add missing field annotations in space.proto, message.proto, reaction.proto, space_event.proto, membership.proto, attachment.proto ([#11246](https://togithub.com/googleapis/google-cloud-go/issues/11246)) ([ca8d4c3](https://togithub.com/googleapis/google-cloud-go/commit/ca8d4c36476b2834fca7500368a3f09bea12bd08)) </details> <details><summary>cloudbuild: 1.19.1</summary> ## [1.19.1](https://togithub.com/googleapis/google-cloud-go/compare/cloudbuild/v1.19.0...cloudbuild/v1.19.1) (2024-12-11) ### Bug Fixes * **cloudbuild:** Deprecate apiv1 client ([#11225](https://togithub.com/googleapis/google-cloud-go/issues/11225)) ([ba9412a](https://togithub.com/googleapis/google-cloud-go/commit/ba9412a07cc3b31278c204759c343c5e0c60663f)) </details> <details><summary>compute: 1.30.0</summary> ## [1.30.0](https://togithub.com/googleapis/google-cloud-go/compare/compute/v1.29.0...compute/v1.30.0) (2024-12-11) ### Features * **compute:** Update Compute Engine API to revision 20241201 ([#966](https://togithub.com/googleapis/google-cloud-go/issues/966)) ([#11250](https://togithub.com/googleapis/google-cloud-go/issues/11250)) ([76266a6](https://togithub.com/googleapis/google-cloud-go/commit/76266a619b4a2178c21de4d330f751bffc84994e)) </details> <details><summary>dialogflow: 1.63.0</summary> ## [1.63.0](https://togithub.com/googleapis/google-cloud-go/compare/dialogflow/v1.62.0...dialogflow/v1.63.0) (2024-12-11) ### Features * **dialogflow:** Properly mark TrainingPhrase name field output-only ([57fdec7](https://togithub.com/googleapis/google-cloud-go/commit/57fdec7ce3792753c419298b9e526c4889f4101d)) ### Documentation * **dialogflow:** Fixed the references to proto method / fields ([57fdec7](https://togithub.com/googleapis/google-cloud-go/commit/57fdec7ce3792753c419298b9e526c4889f4101d)) </details> <details><summary>maps: 1.17.0</summary> ## [1.17.0](https://togithub.com/googleapis/google-cloud-go/compare/maps/v1.16.0...maps/v1.17.0) (2024-12-11) ### Features * **maps/routing:** Add API for experimental flyover and narrow road polyline details ([#11220](https://togithub.com/googleapis/google-cloud-go/issues/11220)) ([57fdec7](https://togithub.com/googleapis/google-cloud-go/commit/57fdec7ce3792753c419298b9e526c4889f4101d)) ### Documentation * **maps/fleetengine:** Correct SearchVehiclesRequest.ordered_by description ([76266a6](https://togithub.com/googleapis/google-cloud-go/commit/76266a619b4a2178c21de4d330f751bffc84994e)) * **maps/routeoptimization:** Update reference doc links ([38385d4](https://togithub.com/googleapis/google-cloud-go/commit/38385d441ba43e7bf6166ee5507a70e77c0b01f5)) </details> <details><summary>oracledatabase: 0.1.2</summary> ## [0.1.2](https://togithub.com/googleapis/google-cloud-go/compare/oracledatabase/v0.1.1...oracledatabase/v0.1.2) (2024-12-11) ### Documentation * **oracledatabase:** A comment for field `cpu_count` in message `.google.cloud.oracledatabase.v1.CloudExadataInfrastructureProperties` is changed ([d448fbb](https://togithub.com/googleapis/google-cloud-go/commit/d448fbb8ff228b1081ebbc98ee13e2a49e2b373c)) * **oracledatabase:** A comment for field `db_node_storage_size_gb` in message `.google.cloud.oracledatabase.v1.CloudExadataInfrastructureProperties` is changed ([d448fbb](https://togithub.com/googleapis/google-cloud-go/commit/d448fbb8ff228b1081ebbc98ee13e2a49e2b373c)) * **oracledatabase:** A comment for field `memory_size_gb` in message `.google.cloud.oracledatabase.v1.CloudExadataInfrastructureProperties` is changed ([d448fbb](https://togithub.com/googleapis/google-cloud-go/commit/d448fbb8ff228b1081ebbc98ee13e2a49e2b373c)) </details> <details><summary>orchestration: 1.11.2</summary> ## [1.11.2](https://togithub.com/googleapis/google-cloud-go/compare/orchestration/v1.11.1...orchestration/v1.11.2) (2024-12-11) ### Documentation * **orchestration/airflow/service:** Add examples for kubernetes secret ([#11236](https://togithub.com/googleapis/google-cloud-go/issues/11236)) ([38385d4](https://togithub.com/googleapis/google-cloud-go/commit/38385d441ba43e7bf6166ee5507a70e77c0b01f5)) </details> <details><summary>parallelstore: 0.9.0</summary> ## [0.9.0](https://togithub.com/googleapis/google-cloud-go/compare/parallelstore/v0.8.0...parallelstore/v0.9.0) (2024-12-11) ### Features * **parallelstore:** A new enum `DeploymentType` is added ([57fdec7](https://togithub.com/googleapis/google-cloud-go/commit/57fdec7ce3792753c419298b9e526c4889f4101d)) * **parallelstore:** A new field `deployment_type` is added to message `.google.cloud.parallelstore.v1beta.Instance` ([57fdec7](https://togithub.com/googleapis/google-cloud-go/commit/57fdec7ce3792753c419298b9e526c4889f4101d)) </details> <details><summary>shopping: 0.13.0</summary> ## [0.13.0](https://togithub.com/googleapis/google-cloud-go/compare/shopping/v0.12.1...shopping/v0.13.0) (2024-12-11) ### Features * **shopping/merchant/products:** A new field `member_price_effective_date` is added to message `.google.shopping.merchant.products.v1beta.LoyaltyProgram` ([279350e](https://togithub.com/googleapis/google-cloud-go/commit/279350e1703dd7f251603408bf0381d47b87ba60)) * **shopping/merchant/products:** A new field `shipping_label` is added to message `.google.shopping.merchant.products.v1beta.LoyaltyProgram` ([279350e](https://togithub.com/googleapis/google-cloud-go/commit/279350e1703dd7f251603408bf0381d47b87ba60)) ### Bug Fixes * **shopping/merchant/products:** An existing field `gtin` is moved out of oneof in message `.google.shopping.merchant.products.v1beta.Attributes` ([279350e](https://togithub.com/googleapis/google-cloud-go/commit/279350e1703dd7f251603408bf0381d47b87ba60)) * **shopping/merchant/products:** Changed repeated flag of an existing field `gtin` in message `.google.shopping.merchant.products.v1beta.Attributes` ([#11247](https://togithub.com/googleapis/google-cloud-go/issues/11247)) ([279350e](https://togithub.com/googleapis/google-cloud-go/commit/279350e1703dd7f251603408bf0381d47b87ba60)) ### Documentation * **shopping/merchant/products:** A comment for field `gtin` in message `.google.shopping.merchant.products.v1beta.Attributes` is changed ([279350e](https://togithub.com/googleapis/google-cloud-go/commit/279350e1703dd7f251603408bf0381d47b87ba60)) * **shopping/merchant/products:** A comment for field `max_handling_time` in message `.google.shopping.merchant.products.v1beta.Shipping` is changed ([279350e](https://togithub.com/googleapis/google-cloud-go/commit/279350e1703dd7f251603408bf0381d47b87ba60)) * **shopping/merchant/products:** A comment for field `max_transit_time` in message `.google.shopping.merchant.products.v1beta.Shipping` is changed ([279350e](https://togithub.com/googleapis/google-cloud-go/commit/279350e1703dd7f251603408bf0381d47b87ba60)) * **shopping/merchant/products:** A comment for field `min_handling_time` in message `.google.shopping.merchant.products.v1beta.Shipping` is changed ([279350e](https://togithub.com/googleapis/google-cloud-go/commit/279350e1703dd7f251603408bf0381d47b87ba60)) * **shopping/merchant/products:** A comment for field `min_transit_time` in message `.google.shopping.merchant.products.v1beta.Shipping` is changed ([279350e](https://togithub.com/googleapis/google-cloud-go/commit/279350e1703dd7f251603408bf0381d47b87ba60)) * **shopping/merchant/products:** A comment for field `name` in message `.google.shopping.merchant.products.v1beta.DeleteProductInputRequest` is changed ([279350e](https://togithub.com/googleapis/google-cloud-go/commit/279350e1703dd7f251603408bf0381d47b87ba60)) * **shopping/merchant/products:** A comment for field `name` in message `.google.shopping.merchant.products.v1beta.GetProductRequest` is changed ([279350e](https://togithub.com/googleapis/google-cloud-go/commit/279350e1703dd7f251603408bf0381d47b87ba60)) * **shopping/merchant/products:** A comment for field `name` in message `.google.shopping.merchant.products.v1beta.Product` is changed ([279350e](https://togithub.com/googleapis/google-cloud-go/commit/279350e1703dd7f251603408bf0381d47b87ba60)) * **shopping/merchant/products:** A comment for field `name` in message `.google.shopping.merchant.products.v1beta.ProductInput` is changed ([279350e](https://togithub.com/googleapis/google-cloud-go/commit/279350e1703dd7f251603408bf0381d47b87ba60)) * **shopping/merchant/products:** A comment for field `page_size` in message `.google.shopping.merchant.products.v1beta.ListProductsRequest` is changed ([279350e](https://togithub.com/googleapis/google-cloud-go/commit/279350e1703dd7f251603408bf0381d47b87ba60)) * **shopping/merchant/products:** A comment for field `tax_category` in message `.google.shopping.merchant.products.v1beta.Attributes` is changed ([279350e](https://togithub.com/googleapis/google-cloud-go/commit/279350e1703dd7f251603408bf0381d47b87ba60)) * **shopping/merchant/products:** A comment for message `Product` is changed ([279350e](https://togithub.com/googleapis/google-cloud-go/commit/279350e1703dd7f251603408bf0381d47b87ba60)) * **shopping/merchant/products:** A comment for message `ProductInput` is changed ([279350e](https://togithub.com/googleapis/google-cloud-go/commit/279350e1703dd7f251603408bf0381d47b87ba60)) </details> --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(shopping/merchant/products): An existing field
gtin
is moved out of oneof in message.google.shopping.merchant.products.v1beta.Attributes
docs(shopping/merchant/products): A comment for message
ProductInput
is changeddocs(shopping/merchant/products): A comment for field
name
in message.google.shopping.merchant.products.v1beta.ProductInput
is changeddocs(shopping/merchant/products): A comment for field
name
in message.google.shopping.merchant.products.v1beta.DeleteProductInputRequest
is changeddocs(shopping/merchant/products): A comment for message
Product
is changeddocs(shopping/merchant/products): A comment for field
name
in message.google.shopping.merchant.products.v1beta.Product
is changeddocs(shopping/merchant/products): A comment for field
name
in message.google.shopping.merchant.products.v1beta.GetProductRequest
is changeddocs(shopping/merchant/products): A comment for field
page_size
in message.google.shopping.merchant.products.v1beta.ListProductsRequest
is changeddocs(shopping/merchant/products): A comment for field
gtin
in message.google.shopping.merchant.products.v1beta.Attributes
is changeddocs(shopping/merchant/products): A comment for field
tax_category
in message.google.shopping.merchant.products.v1beta.Attributes
is changeddocs(shopping/merchant/products): A comment for field
min_handling_time
in message.google.shopping.merchant.products.v1beta.Shipping
is changeddocs(shopping/merchant/products): A comment for field
max_handling_time
in message.google.shopping.merchant.products.v1beta.Shipping
is changeddocs(shopping/merchant/products): A comment for field
min_transit_time
in message.google.shopping.merchant.products.v1beta.Shipping
is changeddocs(shopping/merchant/products): A comment for field
max_transit_time
in message.google.shopping.merchant.products.v1beta.Shipping
is changedfeat(shopping/merchant/products): A new field
member_price_effective_date
is added to message.google.shopping.merchant.products.v1beta.LoyaltyProgram
feat(shopping/merchant/products): A new field
shipping_label
is added to message.google.shopping.merchant.products.v1beta.LoyaltyProgram
PiperOrigin-RevId: 704281512
Source-Link: googleapis/googleapis@0f1beb9
Source-Link: https://github.com/googleapis/googleapis-gen/commit/5429d7d40b248ad0347e916defee17ba51164011
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTQyOWQ3ZDQwYjI0OGFkMDM0N2U5MTZkZWZlZTE3YmE1MTE2NDAxMSJ9