Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(bigquery): migrate trace testing from opencensus to otel #11231

Merged
merged 4 commits into from
Dec 6, 2024
Merged

test(bigquery): migrate trace testing from opencensus to otel #11231

merged 4 commits into from
Dec 6, 2024
+30 −21

Conversation

shollyman
Copy link
Contributor

No description provided.

@shollyman shollyman requested review from a team as code owners December 5, 2024 21:00
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Dec 5, 2024
@alvarowolfx
Copy link
Contributor

@shollyman I think we should migrate this to otel instead of just deleting the trace integration test. We recently solved a issue with PR #11119 that added more test scenario to that file.

@shollyman
Copy link
Contributor Author

@shollyman I think we should migrate this to otel instead of just deleting the trace integration test. We recently solved a issue with PR #11119 that added more test scenario to that file.

Fair. My intent was to kill opencensus in this PR and introduce opentelemetry in another PR, but I can do the migration in one shot.

@shollyman shollyman changed the title test(bigquery): remove legacy opencensus trace testing test(bigquery): migrate trace testing from opencensus to otel Dec 5, 2024
@shollyman
Copy link
Contributor Author

@shollyman I think we should migrate this to otel instead of just deleting the trace integration test. We recently solved a issue with PR #11119 that added more test scenario to that file.

Fair. My intent was to kill opencensus in this PR and introduce opentelemetry in another PR, but I can do the migration in one shot.

Migration completed. PTAL.

@shollyman shollyman added the automerge Merge the pull request once unit tests and other checks pass. label Dec 6, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 7e4ada8 into googleapis:main Dec 6, 2024
9 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 6, 2024
@shollyman shollyman deleted the more-like-closedcensus-amirite branch December 6, 2024 17:25
@alvarowolfx alvarowolfx mentioned this pull request Dec 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarowolfx alvarowolfx alvarowolfx approved these changes

@quartzmo quartzmo Awaiting requested review from quartzmo

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shollyman @alvarowolfx