Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add Writer.ChunkTransferTimeout #11111

Merged
merged 23 commits into from
Dec 4, 2024

Conversation

Tulsishah
Copy link
Contributor

@Tulsishah Tulsishah commented Nov 11, 2024

Expose the ChunkTransferTimeout MediaOption through the manual
client layer. This allows users to set a longer timeout for
chunk retries in case of stalls in resumable uploads if desired.

Added emulator based unit tests to cover all the scenarios.

Copy link

conventional-commit-lint-gcf bot commented Nov 11, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Nov 11, 2024
@Tulsishah Tulsishah force-pushed the transfertimeout_init branch 2 times, most recently from 46290c0 to b0fa899 Compare November 11, 2024 03:52
@Tulsishah Tulsishah force-pushed the transfertimeout_init branch from 2d3b63a to adf32f8 Compare November 21, 2024 15:55
@Tulsishah Tulsishah marked this pull request as ready for review November 22, 2024 02:50
@Tulsishah Tulsishah requested review from a team as code owners November 22, 2024 02:50
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions on testing/docs

storage/client_test.go Outdated Show resolved Hide resolved
storage/client_test.go Outdated Show resolved Hide resolved
storage/client_test.go Outdated Show resolved Hide resolved
storage/client_test.go Outdated Show resolved Hide resolved
storage/writer.go Outdated Show resolved Hide resolved
storage/writer.go Outdated Show resolved Hide resolved
@Tulsishah Tulsishah changed the title feat(storage): add Writer.ChunkTransferTimeOut feat(storage): add Writer.ChunkTransferTimeout Nov 25, 2024
@tritone tritone added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 26, 2024
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can merge once the apiary release happens and dependency is picked up.

@Tulsishah Tulsishah force-pushed the transfertimeout_init branch from 85f44db to 46056b3 Compare December 4, 2024 18:03
@Tulsishah Tulsishah force-pushed the transfertimeout_init branch from 46056b3 to 092400e Compare December 4, 2024 18:12
@Tulsishah Tulsishah force-pushed the transfertimeout_init branch 3 times, most recently from 4246d5b to de93ea1 Compare December 4, 2024 18:21
@tritone tritone removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 4, 2024
@tritone tritone added the automerge Merge the pull request once unit tests and other checks pass. label Dec 4, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit fd1db20 into googleapis:main Dec 4, 2024
10 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants