-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): add Writer.ChunkTransferTimeout #11111
feat(storage): add Writer.ChunkTransferTimeout #11111
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
46290c0
to
b0fa899
Compare
2d3b63a
to
adf32f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions on testing/docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we can merge once the apiary release happens and dependency is picked up.
85f44db
to
46056b3
Compare
46056b3
to
092400e
Compare
4246d5b
to
de93ea1
Compare
Expose the ChunkTransferTimeout MediaOption through the manual
client layer. This allows users to set a longer timeout for
chunk retries in case of stalls in resumable uploads if desired.
Added emulator based unit tests to cover all the scenarios.