Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storage): adding dynamic delay algorithm #10838

Merged
merged 9 commits into from
Sep 16, 2024
Merged

chore(storage): adding dynamic delay algorithm #10838

merged 9 commits into from
Sep 16, 2024
+330 −0

Conversation

raj-prince
Copy link
Contributor

@raj-prince raj-prince commented Sep 10, 2024 •
edited
Loading

Adding go-routine safe dynamic delay algorithm that calculates the delay at a fixed percentile, based on delay samples.

@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Sep 10, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Sep 10, 2024
@raj-prince raj-prince changed the title feat (storage): Adding algorithm to calculate dynamic delay at a fixed percentile feat (storage): Adding dynamic delay algorithm Sep 10, 2024
@raj-prince raj-prince changed the title feat (storage): Adding dynamic delay algorithm feat (storage): adding dynamic delay algorithm Sep 10, 2024
@raj-prince raj-prince changed the title feat (storage): adding dynamic delay algorithm feat(storage): adding dynamic delay algorithm Sep 10, 2024
@raj-prince raj-prince marked this pull request as ready for review September 10, 2024 02:15
@raj-prince raj-prince requested review from a team as code owners September 10, 2024 02:15
tritone
tritone reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks pretty good, I think the main change would be to move the pkg location and remove any exported types.

storage/util/dynamic_percentile.go Outdated Show resolved Hide resolved
storage/util/dynamic_percentile.go Outdated Show resolved Hide resolved
storage/util/dynamic_percentile.go Outdated Show resolved Hide resolved
storage/util/dynamic_percentile.go Outdated Show resolved Hide resolved
@raj-prince raj-prince requested a review from tritone September 13, 2024 11:02
tritone
tritone approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Prince.

@tritone tritone changed the title feat(storage): adding dynamic delay algorithm chore(storage): adding dynamic delay algorithm Sep 16, 2024
@tritone tritone merged commit 4265acc into googleapis:main Sep 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raj-prince @tritone