Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust priority of quota project sources #10805

Closed
wants to merge 1 commit into from

Conversation

michalskalski
Copy link

'GOOGLE_CLOUD_QUOTA_PROJECT' env variable should override quota project setting from credentials file. This is a behavior of previous auth code: https://github.com/googleapis/google-api-go-client/blob/main/internal/creds.go#L242-L261

It is trying to solve issue described in #10804

To activate it would required additional change in https://github.com/googleapis/google-api-go-client: googleapis/google-api-go-client#2767

@michalskalski michalskalski requested a review from a team as a code owner September 2, 2024 05:18
Copy link

google-cla bot commented Sep 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

'GOOGLE_CLOUD_QUOTA_PROJECT' env variable should override quota project
setting from credentials file. This is a behavior of previous auth code:
https://github.com/googleapis/google-api-go-client/blob/main/internal/creds.go#L242-L261
@codyoss
Copy link
Member

codyoss commented Sep 3, 2024

Please see comments on the associated issue. I would like something like these changes in the library. There is just some other associated changes that would need to happen at the same time. If you would like to work on this I am happy to explain more in the new issue I created for this request, but if not that is fine to and we will get to it in the not too distant future. Thanks again.

@codyoss codyoss closed this Sep 3, 2024
@michalskalski
Copy link
Author

@codyoss if you have some general idea how you would like to see this being solved in long term, please share it in the issue. I will try find time to implement. If you already know specifically how this should be implemented and it just matter of finding time, then I don't mind wait for your implementation. What is currently in repo already fixed my initial problem

@codyoss
Copy link
Member

codyoss commented Sep 4, 2024

@michalskalski We will get to it 😄 Just wanted to make sure I was not stealing an oppertunity away if you wanted to make a contribution. Thanks again for the report and glad the PR fixed the issue for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants