Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(spanner): unskip pg integeration tests against emulator #10628

Merged
merged 2 commits into from
Sep 13, 2024
Merged

chore(spanner): unskip pg integeration tests against emulator #10628

merged 2 commits into from
Sep 13, 2024

Conversation

hengfengli
Copy link
Contributor

This PR includes changes:

  • Unskip PG integration tests against the emulator
  • kill -2 does not really kill the emulator process
  • Removed some unused testing helper functions

@hengfengli hengfengli requested review from a team as code owners August 2, 2024 01:27
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Aug 2, 2024
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2024
@rahul2393 rahul2393 enabled auto-merge (squash) September 13, 2024 04:14
@rahul2393 rahul2393 merged commit 27c7188 into googleapis:main Sep 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hengfengli @rahul2393