feat(spanner): demonstrate enhanced row not found handling options #10031 #10358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
husam-e
commented
Jun 11, 2024
| @@ -326,7 +328,8 @@ func (t *txReadOnly) ReadWithOptions(ctx context.Context, table string, keys Key | |||
| // errRowNotFound returns error for not being able to read the row identified by | |||
| // key. | |||
| func errRowNotFound(table string, key Key) error { | |||
| return spannerErrorf(codes.NotFound, "row not found(Table: %v, PrimaryKey: %v)", table, key) | |||
| details := []protoadapt.MessageV1{&errdetails.ErrorInfo{Reason: RowNotFoundReason}} | |||
There was a problem hiding this comment.
option 1: specify an explicit and exported Reason value in details.ErrorInfo.Reason, and do the same for ReadRowUsingIndex
| // This is a convenience function to simplify use cases that want to treat | ||
| // a missing row as nil in a reliable manner, without matching against the | ||
| // error message. | ||
| func (t *txReadOnly) ReadRowOptional(ctx context.Context, table string, key Key, columns []string) (*Row, error) { |
There was a problem hiding this comment.
option 2: additional API for treating row not found as nil and not an error (and doing the same for ReadRowUsingIndex
|
Addressed in #10405, thanks @rahul2393 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is just an example (that may not build successfully yet) demonstrating 2 options for enhancing row not found handling, which is currently not explicit when using
ReadRow/ReadRowUsingIndex, as discussed in #10031:Details.ErrorInfo.Reasonto a well-defined value that can be checked by users to reliably determine if an error is specifically due to a row not being found (as opposed to column/table not found which returns the same error code).nilwhen the row is not found (calledReadRowOptional). An equivalent API would be added forReadRowUsingIndex(ReadRowOptionalUsingIndex).